wtijsma
-
12/28/2004 9:59:43 AM
TWEAK: Remove Microsoft.VisualBasic dependency
I know this is nothing I should be worried about, but I would like to remove Microsoft.VisualBasic dependency...
things like this:
if (SortField == null || Strings.Trim(SortField + "") + "" == "")
could easily replaced by this:
(SortField == null || SortField.Trim() == string.Empty)
generally, always try to use 'OrElse' and 'AndAlso' (if I remember correctly, I don't do VB) because it wil prevent the next statement from being executed (so in this case the SortField.Trim() will never be executed if SortField is null)
Please try to use the .NET constants: Environment.Newline instead of "\n" and Constants.vbCrLf , string.Empty instead of "" for better readability and compatibility.
Again, I would really prefer some shared CVS, because I'm fixing all these things if I encounter them, but if I do that, the next version will just override my changes.
|